Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop-ref after dtcenter/MET#2967 #2689

Merged
merged 1,077 commits into from
Sep 10, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Fixes integer overflow bug in the computation of the CTS and NBRCTS ORSS, ORSS_NCL, and ORSS_NCU columns.
Created by @JohnHalleyGotway

georgemccabe and others added 30 commits July 25, 2023 12:13
Co-authored-by: Dan Adriaansen <dadriaan@ucar.edu>
* Updating installation files

* Removing run_commands.sh

* Updated the file to add a MINICONDA_PATH

* Adding files for jet

* Adding orion file

* Removing beta references

* Corrected met version

* Adding files for WCOSS2 machines

* Removing rc1 from acorn file

* Removing beta1
…at causes GHA disk to exceed capacity when too many data volumes are created. Use specific commit of coveralls python action to ensure it will not change
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
…n a pull request from a fork because the authentication fails
… to push this change and the NOAA OAR reporting label to all the METplus repos.
…lso fixing the get_lablels.sh to search for up to 200 existing labels. Also work on the log messages.
metplus-bot and others added 26 commits May 22, 2024 19:42
…to update *-ref branches and commit/append to a log file that tracks the reasons for updating the truth data. This is done to ensure that the *-ref branch testing workflow run that actually updates the truth data is always run even if there are no other changes to the METplus branch since the last update, e.g. when a change to another component like MET warrants the truth data update
…tead merge changes from -ref into the update branch
… Embedding in PointStat and EnsembleStat, which should fix the PBL use case -- #2246 -- so turned on diff test for PBL use case to ensure that results are consistent going forward
* prevent divide by zero if run_count is 0

* Per #2547, add support for setting -valid_beg and -valid_end command line arguments. Added changes to make ASCII2NC wrapper able to run for all runtime frequencies

* Refactored system_util preprocess_file function to reduce cognitive complexity and add quotation marks around 'filenames' that contain spaces (typically python embedding commands) so explicit handling of these cases don't need to be done downstream. Added unit tests to test more python embedding cases

* remove logic to add quotes around input file since it is handled already in preprocess_file

* changed find_input_files function to return None or a time_info dictionary to be consistent across wrappers

* added ReformatPointWrapper to use as parent class for ASCII2NC, MADIS2NC, PB2NC, and Point2Grid wrappers to consistently handle tools that reformat point observation data. Moved verbosity to the end of commands

* clean up pb2nc wrapper to be more consistent with other ReformatPoint wrappers

* per #2547, added glossary entries for new config variables to set -valid_beg/end and added commented example to basic use case config file

* added glossary entries for *_RUNTIME_FREQ variables

* Per #2513, remove TC_RMW_MAX_RANGE_KM
* Updated for new data

* Updated to match new data

* Updates due to new data/updates to data

* Updates due to new data/data variables

* Changes due to changes to data variables, date

* Updates due to changes to data

* Update the date to reflect the new data (with updates to variables)

* fixed error with formatting

* Remove redundant instructions.

* For testing

* Update use_case_groups.json

* Revert to original location of input data to use the same data for all three FV3 Physics Tendency use cases.

* Revert to original location of data from tarball

* Remove typo in file directory name

* Update use_case_groups.json

Returned 10-12 to follow 11

* Update use_case_groups.json

revert to false for testing the short range use cases for  FV3 physics tendency

* Update use_case_groups.json

fix alignment of opening curly brace

* Update use_case_groups.json

revert to original formatting

* removed config variable that should be set by the user because it is specific to the user's environment

---------

Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
* refactoring to reduce duplicate/redundant code, reduce cognitive complexity to satisfy SonarQube, etc

* change wording of error log to satisfy test

* set -input_thresh argument if set for add, derive, and sum methods. refactor setting of method arguments, e.g. -add, -sum, etc., cleanup

* refactor how level is handled in find_data function so that if the level has already been set, it will use that value, otherwise try to get it from {data_type}_level, e.g. fcst_level, otherwise set it to 0 to prevent errors

* refactor duplicate code into function to satisfy SonarQube

* removed unused variable

* use find_data function to find input files to be consistent with other wrappers, only allow multiple input files to be found for a given call to find_data if using the -derive method

* fix typo in key

* suppress warnings when files aren't found because it is expected

* formatting to be consistent in doc string

* per #2578, add MISSING before file path that is not found if input_thresh is set and less than 1.0, added unit test to ensure correct behavior occurs

* add documentation blocks for new functions, ci-run-all-diff

* use pytest fixture instead of local function

* add support for setting -vld_thresh argument

* per #2578, added documentation and tests for setting -input_thresh and -vld_thresh

* moved verbosity argument to end of command to more easily change it when debugging

* refactor to reduce cognitive complexity to satisfy SonarQube

* update usage statement to include METplus version number
* add copy button for code blocks to easily copy/paste commands

* turn off copy button always visible but leave code block so it can be turned on easily if desired
Update METplus-6.0.0 development schedule.
* Initial commit for QBO driver

* Adding initial documentation for Stratosphere

* Updating documentation typo

* Updates to Polar plot

* Updates to Stratosphere use cases and documentation

* Updates to polar use case

* Updating documentation

* Updates to Polar and QBO

* Updated documentation for use cases that cannot be run in actions

* Removed some unnecessary imports

* Fixed staging dir settings

* documentation update

* More documentation edits

* More updates

* Fixed link in documentation

* Updating documentation

* Updated bullet list

* More updates

* Added some additional comments to the .conf file

* Fixed typo in output file name in documentation

* Updated output section of documentation

* Updated documentation

* Fixed list that was not working

* Updated broken link

* Fixed broken link again

* Fixed another typo

* Trying to fix documentation error

* Trying to fix indent error

* fixed capital typo

* Added clarification
* update version and added release notes

* Per #2626, updating dates

---------

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
* Per #2656, update the read_iodav2_mpr.py scripts to write 3 additional values of NA in each MPR line corresponding to the OBS_CLIMO_CDF, FCST_CLIMO_MEAN, and FCST_CLIMO_STDEV columns.

* Per #2656, update the ugrid_lfric_mpr.py to write 3 additional values of NA in each MPR line corresponding to the OBS_CLIMO_CDF, FCST_CLIMO_MEAN, and FCST_CLIMO_STDEV columns.
@JohnHalleyGotway JohnHalleyGotway added this to the METplus-6.0.0 milestone Sep 10, 2024
@JohnHalleyGotway JohnHalleyGotway linked an issue Sep 10, 2024 that may be closed by this pull request
11 tasks
@JohnHalleyGotway JohnHalleyGotway merged commit 29d0ea0 into develop-ref Sep 10, 2024
1 check passed
@JohnHalleyGotway JohnHalleyGotway deleted the update_develop_59d4726e branch September 10, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Update Truth: For dtcenter/MET#2967